Replace the deprecated datetime.datetime.utcfromtimestamp - #62
Merged
pombredanne merged 1 commit intoSep 5, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Apparently, the DCO check fails due to using the GitHub username instead of the display name and a non-GitHub e-mail address for signing. |
Sorry, something went wrong.
Signed-off-by: stefan6419846 <96178532+stefan6419846@users.noreply.github.com>
Copy link
Copy Markdown
Contributor
Author
|
The DCO part should finally be fixed now. |
Sorry, something went wrong.
pombredanne
approved these changes
Sep 5, 2024
pombredanne
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
I made a few changes to avoid import issues.
Sorry, something went wrong.
Comment thread
src/commoncode/filetype.py
Comment thread
src/commoncode/filetype.py
Comment thread
src/commoncode/filetype.py
pombredanne
approved these changes
Sep 5, 2024
pombredanne
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks. Merging as is after all!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #61.
Please point out if further changes such as a changelog entry or a corresponding test (there does not seem to be one?) are desired/required.