Add Android App Bundle (.aab) file support. - #68
Open
ArkaprabhaChakraborty wants to merge 3 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Signed-off-by: ArkaprabhaChakraborty <chakrabortyarkaprabha998@gmail.com>
ArkaprabhaChakraborty
force-pushed
the
aab_extract
branch
from
117894b to
bea6f71
Compare
January 25, 2025 12:00
Copy link
Copy Markdown
Author
|
Checked the CI job. My tests have passed but there are others that are breaking: tests/test_androidappbundle.py::TestExtractAAB::test_can_identify_aab_file tests/test_androidappbundle.py::TestExtractAAB::test_can_extract_aab_file [gw1] PASSED tests/test_androidappbundle.py::TestExtractAAB::test_can_identify_aab_file tests/test_androidappbundle.py::TestExtractAAB::test_extract_aab_nonexistent_file [gw1] PASSED tests/test_androidappbundle.py::TestExtractAAB::test_extract_aab_nonexistent_file tests/test_archive.py::TestGetExtractorTest::test_7zip_extract_can_extract_to_relative_paths |
Sorry, something went wrong.
Signed-off-by: ArkaprabhaChakraborty <chakrabortyarkaprabha998@gmail.com>
Signed-off-by: ArkaprabhaChakraborty <chakrabortyarkaprabha998@gmail.com>
pombredanne
requested changes
Jan 29, 2025
pombredanne
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks...
- Can you find a very tiny bundle for testing? We also need to know where it is coming from and add an .ABOUT file to document its origin if possible, or a note explaining how to create it. Then please amend your commit with this small file
- Is an aab a zip? if this is so, you should just add a handler for this as in ... Do not recreate zip extraction. Same with the tests, if this a zip, then just add that file to the zip tests.
extractcode/src/extractcode/archive.py
Line 510 in db9dd08
- Is this code that was generated somehow? We are not against it, but this need to be stated upfront.
Generated code is most often approximate, and non-integrated in the rest of the code like your code here and it requires an inordinate amount of effort from maintainers to review, so we need to know
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Yess .aab is signed zipfile. No it wasn't generated but I do use GitHub
copilot free automcomplete extensions so it helps me with comments and
documents. Actually I didn't know where to start so I decided to create a
new file for it so that at least the idea can be presented. I did see a
zipfile extractor already present but needed some information like how the information should be parsed and in what way it should be stored so that any other module could use it. I'll add
the tests and handler to zipfile.
…On Wed, Jan 29, 2025, 3:40 PM Philippe Ombredanne ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Thanks...
1. Can you find a very tiny bundle for testing? We also need to know
where it is coming from and add an .ABOUT file to document its origin if
possible, or a note explaining how to create it. Then please amend your
commit with this small file
2. Is an aab a zip? if this is so, you should just add a handler for
this as in
https://github.com/aboutcode-org/extractcode/blob/db9dd083239302220b996bcf9c1914cd5c3ff016/src/extractcode/archive.py#L510
... Do not recreate zip extraction. Same with the tests, if this a zip,
then just add that file to the zip tests.
3. Is this code that was generated somehow? We are not against it, but
this need to be stated upfront.
*Generated code is most often approximate, and non-integrated in the rest
of the code like your code here and it requires an inordinate amount of
effort from maintainers to review, so we need to know*
—
Reply to this email directly, view it on GitHub
<#68 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AN6F3GM5MNS6I4YV6PQRMFT2NCSKHAVCNFSM6AAAAABV3I5GY2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOBQGU2TMMRUHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: aboutcode-org/scancode-toolkit#3640