[For Review Purpose Only-Do not Merge] First Draft for Glibc Importer - #1414
Closed
harsh098 wants to merge 4 commits into
Closed
[For Review Purpose Only-Do not Merge] First Draft for Glibc Importer#1414harsh098 wants to merge 4 commits into
harsh098 wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
TG1999
requested changes
Feb 12, 2024
TG1999
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Some nits as per my initial review
Sorry, something went wrong.
Comment thread
vulnerabilities/importers/glibc.py
Outdated
Comment thread
vulnerabilities/importers/glibc.py
Comment thread
vulnerabilities/importers/glibc.py
Outdated
Comment thread
vulnerabilities/importers/glibc.py
Outdated
Comment thread
vulnerabilities/tests/test_glibc.py
Comment thread
vulnerabilities/importers/glibc.py
TG1999
marked this pull request as draft
February 12, 2024 16:09
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
harsh098
force-pushed
the
glibc_importer
branch
from
7a282af to
1a1ffa8
Compare
February 25, 2024 07:54
Closed
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Copy link
Copy Markdown
Contributor
Author
|
First draft for importer published. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@harsh098 closing this PR, feel free to open this once it's ready for review |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #1362.
Parser has been added in order to review the parser for GLIBC Importer.
@TG1999 and @pombredanne please have a look.