FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove orphan jquery-form and toastr npm packages by maliming · Pull Request #26002 · abpframework/abp · GitHub

Remove orphan jquery-form and toastr npm packages - #26002

Merged
maliming merged 2 commits into
devfrom
maliming/remove-jquery-form-toastr-packs
Aug 21, 2026
Merged

Remove orphan jquery-form and toastr npm packages#26002
maliming merged 2 commits into
devfrom
maliming/remove-jquery-form-toastr-packs

Conversation

Copy link
Copy Markdown
Member

Resolve #25968
Resolve #25966

Both libraries were already replaced (abpAjaxForm uses FormData + $.ajax, notifications use abp-toast.js); this drops the unused @abp/jquery-form and @abp/toastr packages and cleans the docs.

maliming added this to the 10.8-preview milestone Aug 18, 2026
maliming requested a review from EngincanV August 21, 2026 01:52
maliming marked this pull request as ready for review August 21, 2026 07:38
Copilot AI lite review requested due to automatic review settings August 21, 2026 07:38
maliming merged commit 2b96067 into dev Aug 21, 2026
2 checks passed
maliming deleted the maliming/remove-jquery-form-toastr-packs branch August 21, 2026 07:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

This PR removes the legacy, now-orphaned npm packs that previously shipped the toastr and jquery-form third-party libraries, and updates MVC/Razor Pages documentation to stop referencing those libraries.

Changes:

  • Deleted @abp/toastr npm pack files (package metadata, resource mapping, README).
  • Deleted @abp/jquery-form npm pack files (including the vendored/minified plugin source).
  • Updated MVC/Razor Pages docs to remove Toastr/JQuery Form mentions and adjust bundle examples.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
npm/packs/toastr/README.md Removes the Toastr pack README as part of deprecating the pack.
npm/packs/toastr/package.json Removes the @abp/toastr pack definition.
npm/packs/toastr/abp.resourcemapping.js Removes resource mapping for toastr assets.
npm/packs/jquery-form/src/jquery.form.min.js Removes the vendored/minified jquery-form plugin payload.
npm/packs/jquery-form/README.md Removes the jQuery Form pack README as part of deprecating the pack.
npm/packs/jquery-form/package.json Removes the @abp/jquery-form pack definition.
npm/packs/jquery-form/abp.resourcemapping.js Removes resource mapping for jquery-form assets.
docs/en/framework/ui/mvc-razor-pages/theming.md Removes Toastr/JQuery Form from the base library list and updates notification wording.
docs/en/framework/ui/mvc-razor-pages/overall.md Updates library lists and removes Toastr from bundling examples.
docs/en/framework/ui/mvc-razor-pages/bundling-minification.md Updates bundling examples to avoid referencing Toastr assets.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines 46 to 50
* [SweetAlert](https://sweetalert.js.org/) to show fancy alert message and confirmation dialogs.
* [Toastr](https://github.com/CodeSeven/toastr) to show toast notifications.
* [Lodash](https://lodash.com/) as a utility library.
* [Luxon](https://moment.github.io/luxon/) for date/time operations.
* [JQuery Form](https://github.com/jquery-form/form) for AJAX forms.
* [bootstrap-datepicker](https://github.com/uxsolutions/bootstrap-datepicker) to show date pickers.
* [Select2](https://select2.org/) for better select/combo boxes.

* [Tag Helpers](tag-helpers) makes it easy to generate the Bootstrap UIs.
* JavaScript [Message](javascript-api/message.md) and [Notification](javascript-api/notify.md) APIs provides abstractions to use the Sweetalert and Toastr.
* JavaScript [Message](javascript-api/message.md) and [Notification](javascript-api/notify.md) APIs provides abstractions to use the Sweetalert and the built-in toast implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace jquery-form with fetch + FormData Replace toastr with a Bootstrap Toast based implementation

3 participants


Back | FazBrowse Home | New Git URL