FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Clarify that the empty string is returned if no cache is restored. by lima-limon-inc · Pull Request #1514 · actions/cache · GitHub

/ cache Public

Clarify that the empty string is returned if no cache is restored. - #1514

Open
lima-limon-inc wants to merge 1 commit into
actions:mainfrom
lima-limon-inc:documentation
ConversationCommits (1)ChecksFiles changed
Open

Clarify that the empty string is returned if no cache is restored.#1514
lima-limon-inc wants to merge 1 commit into
actions:mainfrom
lima-limon-inc:documentation

Conversation

lima-limon-inc commented Dec 11, 2024 •
edited
Loading

Copy link
Copy Markdown

Closes: #1513

Description

Update documentation, so that it reflects the actual behavior of cache-hit.

Motivation and Context

The documentation describes a behavior that does not reflect the actual implementation. This caused quite a headache when trying to debug this action.

How Has This Been Tested?

I updated my .yml so that they follow the logic in this PR and they worked correctly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (add or update README or docs)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

lima-limon-inc requested a review from a team as a code owner December 11, 2024 12:28
jshier mentioned this pull request Mar 6, 2025
Open

PaulRBerg commented Apr 16, 2025 •
edited
Loading

Copy link
Copy Markdown

Hey @Dinara255 @TheGiraffe3, could you please merge this PR?

#1566 (comment)

lima-limon-inc commented Apr 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

Hey @Dinara255 @TheGiraffe3, could you please merge this PR?

#1566 (comment)

Hi @PaulRBerg, thanks for your comment! If I'm not mistaken, neither @Dinara255 nor @TheGiraffe3 are maintainers of this repo (do correct me if I'm wrong).

Maybe we should ping @salmanmkc or @robherley, who have recent contributions to the project.

Btw, a more thorough explanation, with code snippets, can be found on the original issue: #1513

lima-limon-inc mentioned this pull request Apr 16, 2025
Open

andreasabel commented May 30, 2025

Copy link
Copy Markdown

See also the fate of my related PR on this issue:

andreasabel approved these changes May 30, 2025
View reviewed changes

andreasabel left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

❤️

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
andreasabel andreasabel approved these changes
TheGiraffe3 TheGiraffe3 approved these changes
Dinara255 Dinara255 approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation is unclear about cache-hit's value when the cache misses.

5 participants

Back | FazBrowse Home | New Git URL