Don't try to download windows exe/msi and mac universal pkg if it doesn't exists for python version requested - #276
Open
jmarrec wants to merge 2 commits into
Open
Don't try to download windows exe/msi and mac universal pkg if it doesn't exists for python version requested#276jmarrec wants to merge 2 commits into
jmarrec wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…t exists for python verrsion requested
Copy link
Copy Markdown
Contributor
|
Rather than silently ignore some network failures that would lead to the version being skipped, the json returned by https://www.python.org/api/v2/downloads/release/?is_published=true/https://www.python.org/api/v2/downloads/release_file/?release=... should be parsed to check if the package exists or not. This shall probably be done while generating the build matrix. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only some minor versions of python have an actual windows .exe / .msi installer.
eg: