| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
Note
Copilot was unable to run its full agentic suite in this review.
Migrates the Zulu (Azul) distribution from the deprecated zulu/download/community/v1.0 API to the new metadata/v1/zulu/packages API, updating request parameters, response model fields, and architecture mapping accordingly.
Changes:
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file| File | Description |
|---|---|
| src/distributions/zulu/models.ts | Updated IZuluVersions interface to new Azul Metadata API schema. |
| src/distributions/zulu/installer.ts | Updated request URL/params, response field references, and simplified getArchitectureOptions to return a single string. |
| tests/distributors/zulu-installer.test.ts | Updated expected URLs and arch mapping assertions for macOS. |
| tests/distributors/zulu-linux-installer.test.ts | Updated expected URLs and arch mapping for Linux. |
| tests/distributors/zulu-windows-installer.test.ts | Updated expected URLs and arch mapping for Windows. |
| tests/data/zulu-windows.json | Regenerated fixture to match new API response schema. |
| tests/data/zulu-linux.json | Regenerated fixture to match new API response schema. |
| tests/data/zulu-releases-default.json | Regenerated fixture to match new API response schema. |
| README.md | Updated note about Zulu architecture mapping. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
|
Unintentionally implemented many of the same changes from #998 although the scope of this PR is a bit narrower. |
Sorry, something went wrong.
Fold CRaC-related work into the Zulu metadata API migration by wiring crac_supported query handling, extending Zulu package docs, and updating installer tests for jdk+crac/jre+crac behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Stop paginating on a short page to avoid an extra empty request - Guard against undefined results (not just null) - Cap iterations at 100 pages and warn if the limit is hit to prevent a runaway loop if the API misbehaves Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The Azul Metadata API returns java_version as a 3-element array (e.g. [17,0,7]) and reports the build number separately in openjdk_build_number. The migration mapped version directly from java_version, dropping the build and breaking exact-version lookups like 17.0.7+7 (e2e failure: "No matching version found for SemVer"). Add openjdk_build_number to IZuluVersions and append it to java_version before converting to semver so resolved versions retain the build (e.g. 17.0.7+7). Update the zulu test fixtures to mirror the real API shape (3-element java_version plus openjdk_build_number) so unit tests exercise the actual response format, and rebuild dist. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Thanks @brunoborges! The additional changes look solid. |
Sorry, something went wrong.
|
Linking the tracking issue: this PR implements #795 (Migrate to the new Azul Metadata API). Maintainers — adding Closes #795 to the PR description will auto-close the issue on merge. |
Sorry, something went wrong.
) * Use Azul metadata API * Document arm64 -> aarch64 mapping in README.md * Paginate through all available versions * Fix typo: win_aarhc4 * Only query for linux_glibc packages * Add Zulu CRaC package support to metadata migration Fold CRaC-related work into the Zulu metadata API migration by wiring crac_supported query handling, extending Zulu package docs, and updating installer tests for jdk+crac/jre+crac behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Harden Zulu metadata pagination with safety cap - Stop paginating on a short page to avoid an extra empty request - Guard against undefined results (not just null) - Cap iterations at 100 pages and warn if the limit is hit to prevent a runaway loop if the API misbehaves Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Preserve JDK build number from Azul Metadata API The Azul Metadata API returns java_version as a 3-element array (e.g. [17,0,7]) and reports the build number separately in openjdk_build_number. The migration mapped version directly from java_version, dropping the build and breaking exact-version lookups like 17.0.7+7 (e2e failure: "No matching version found for SemVer"). Add openjdk_build_number to IZuluVersions and append it to java_version before converting to semver so resolved versions retain the build (e.g. 17.0.7+7). Update the zulu test fixtures to mirror the real API shape (3-element java_version plus openjdk_build_number) so unit tests exercise the actual response format, and rebuild dist. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Bruno Borges <brborges@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> (cherry picked from commit d3530c1)
| Back | FazBrowse Home | New Git URL |
Used Claude Sonnet 4.6 to implement https://docs.azul.com/core/detailed/metadata-api-migration.html. If it's way off the mark then we can close it but if it's salvageable then please feel free to push any necessary commits on top of what is already done although I believe the changes I've made for this PR are complete.
Summary
Migrates the zulu distribution from the deprecated Zulu Discovery API (https://api.azul.com/zulu/download/community/v1.0/bundles/) to the new Azul Metadata API (https://api.azul.com/metadata/v1/zulu/packages/).
Background
The old Zulu Discovery API was returning HTTP 520 errors for a few hours, breaking all distribution: zulu workflows. Since the beginning of 2023 Azul has recommended the Metadata API and published a migration guide.
Changes
src/distributions/zulu/models.ts
Updated IZuluVersions to match the new API response shape:
src/distributions/zulu/installer.ts
README.md
Updated the architecture-mapping note to reflect the new API's conventions (arm64 → aarch64).
Test fixtures and tests
Related issue
Fixes #795
Check list
Fixes #795
Fixes #636