chore: upgrade ESLint to v10 with flat config - #1045
Closed
brunoborges wants to merge 3 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Upgrade ESLint from 8.57.0 to 10.5.0. ESLint 10 removes support for the legacy `.eslintrc` format entirely, so the configuration is migrated to the new flat config (`eslint.config.mjs`). Changes: - Bump `eslint` 8.57.0 -> 10.5.0 and `eslint-plugin-jest` to 29.15.2. - Replace the legacy `@typescript-eslint/eslint-plugin` + `@typescript-eslint/parser` pair with the `typescript-eslint` meta-package (8.62.0), which supports ESLint 10. - Replace the deprecated `eslint-plugin-node` (unmaintained, broken on ESLint 9+) with its maintained fork `eslint-plugin-n` (18.1.0); the single rule in use, `node/no-extraneous-import`, becomes `n/no-extraneous-import`. - Add `@eslint/js` (10.0.1) and `globals` (17.7.0), now required by flat config. - Translate `.eslintrc.js` to `eslint.config.mjs` and `.eslintignore` to the flat config `ignores`, preserving all existing rules and the test-file overrides. - Update the `lint`/`lint:fix` scripts to invoke `eslint` directly (flat config is auto-detected; the `--config ./.eslintrc.js` flag is removed). `preserve-caught-error` (new in ESLint 10's recommended set) is disabled to keep the previous lint behavior; adopting it requires an ES2022 target and is left as a follow-up. Only dev/lint dependencies change, so runtime deps and the built `dist/` output are unchanged. Note: `.eslintrc.js` was previously auto-synced from actions/reusable-workflows. Upstream has not yet published a flat config, so this migration intentionally deviates from that auto-sync until upstream catches up. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the repository’s linting toolchain to ESLint v10 and migrates from legacy .eslintrc to the flat config format (eslint.config.mjs), along with the necessary ecosystem/plugin upgrades to maintain compatibility.
Changes:
- Upgrade ESLint to ^10.5.0 and adjust related lint dependencies (TypeScript ESLint via typescript-eslint, replace eslint-plugin-node with eslint-plugin-n, add @eslint/js and globals).
- Replace .eslintrc.js and .eslintignore with eslint.config.mjs using flat config and equivalent ignores/overrides.
- Update lint / lint:fix npm scripts to run ESLint without explicitly specifying the legacy config file.
| File | Description |
|---|---|
| package.json | Updates lint scripts and devDependencies to ESLint 10 + flat-config-compatible plugins/packages. |
| package-lock.json | Lockfile updates reflecting the new ESLint/tooling dependency graph. |
| eslint.config.mjs | Introduces the flat ESLint configuration with ignores, TS + Jest setup, and updated n/ rule usage. |
| .eslintrc.js | Removes the legacy ESLint configuration (no longer supported in ESLint 10). |
| .eslintignore | Removes legacy ignore file in favor of flat config ignores. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/5 changed files
- Comments generated: 1
Sorry, something went wrong.
Comment thread
package.json
Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This was referenced Jun 22, 2026
Copy link
Copy Markdown
Member
|
I had a quick look into this one myself, I was concerned that there was some automated tooling in place to sync from actions/reusable-workflows. If that's the case this would break this PR. I wonder if it's worth raising a fix in that repo first? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades ESLint from 8.57.0 → 10.5.0. ESLint 10 removes support for the legacy .eslintrc format entirely, so this migrates the configuration to the new flat config (eslint.config.mjs).
This supersedes the standalone Dependabot bump in #1022, which could not work on its own: bumping eslint to 10 without coordinating the @typescript-eslint upgrade and the flat-config migration triggers an ERESOLVE peer conflict (the old @typescript-eslint/eslint-plugin caps eslint at ^9) and leaves the action with an unsupported .eslintrc.js.
Changes
Behavior preservation
Validation
Note on auto-sync
.eslintrc.js was previously auto-synced from actions/reusable-workflows. Upstream has not yet published a flat config, so this migration intentionally deviates from that auto-sync until upstream catches up.