Infer distribution from asdf .tool-versions vendor prefix - #1084
Merged
brunoborges merged 3 commits intoJul 8, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
asdf-java encodes the JDK vendor as a prefix on the version string in .tool-versions (e.g. `java temurin-17.0.3+7`). Capture that prefix and map it to a setup-java distribution, mirroring the existing .sdkmanrc behavior. Unknown prefixes warn and fall back to the distribution input. Fixes #1081 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for inferring distribution from asdf-java vendor prefixes in .tool-versions, bringing it in line with the existing .sdkmanrc distribution inference behavior in actions/setup-java.
Changes:
- Updates .tool-versions parsing to capture an optional vendor prefix into a distribution group and map it to setup-java distributions.
- Introduces mapAsdfDistribution() to normalize asdf-java vendor identifiers (including multi-segment vendors and packaging variants).
- Extends documentation and test coverage with supported vendor mappings and example usage.
| File | Description |
|---|---|
| src/util.ts | Captures asdf vendor prefix from .tool-versions, maps it to a setup-java distribution, and threads it through existing version parsing. |
| __tests__/util.test.ts | Adds .tool-versions test cases for supported vendors, prefix-less behavior, and unsupported vendor warnings. |
| docs/advanced-usage.md | Documents .tool-versions vendor-prefix distribution inference and lists supported mappings + example. |
| dist/setup/index.js | Regenerated compiled distribution output reflecting the updated util logic. |
| dist/cleanup/index.js | Regenerated compiled distribution output reflecting the updated util logic. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/5 changed files
- Comments generated: 1
- Review effort level: Low
Sorry, something went wrong.
Comment thread
src/util.ts
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…tribution-from-tool-versions
This was referenced Jul 8, 2026
zendesk-ops-ci
pushed a commit
to zendesk/setup-java
that referenced
this pull request
Jul 17, 2026
* Infer distribution from asdf .tool-versions vendor prefix asdf-java encodes the JDK vendor as a prefix on the version string in .tool-versions (e.g. `java temurin-17.0.3+7`). Capture that prefix and map it to a setup-java distribution, mirroring the existing .sdkmanrc behavior. Unknown prefixes warn and fall back to the distribution input. Fixes actions#1081 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> (cherry picked from commit 4db08ef)
zendesk-ops-ci
pushed a commit
to zendesk/setup-java
that referenced
this pull request
Jul 17, 2026
actions#1084) Regenerate the CommonJS bundle so the compiled dist/ reflects the source changes backported from main, without the ESM migration (actions#1078). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
asdf's .tool-versions encodes the JDK vendor as a prefix on the version string (for example java temurin-17.0.3+7 or java corretto-11.0.14.9.1). Until now setup-java discarded that prefix, so users pointing java-version-file at a .tool-versions file still had to pass distribution explicitly. .sdkmanrc already infers the distribution; this brings .tool-versions to parity.
Fixes: #1081
What
No caller changes were needed. setup-java.ts already consumes versionInfo.distribution generically.
Vendor mapping
Notes for reviewers
Testing