Fix template injection (zizmor alert #118) in e2e-versions.yml - #1114
Merged
brunoborges merged 2 commits intoJul 14, 2026
Merged
Fix template injection (zizmor alert #118) in e2e-versions.yml#1114brunoborges merged 2 commits into
brunoborges merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copilot
AI
changed the title
[WIP] Fix code scanning alert #118
Fix template injection (zizmor alert #118) in e2e-versions.yml
Jul 14, 2026
brunoborges
marked this pull request as ready for review
July 14, 2026 19:36
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a zizmor/template-injection risk in the e2e-versions GitHub Actions workflow by removing direct ${{ ... }} interpolation from a bash run: block and routing the value through a step-level environment variable instead.
Changes:
- Introduces JAVA_17_PATH as a step-level env variable sourced from steps.setup-java-17.outputs.path.
- Updates the Java 17 JAVA_HOME verification script to compare against $JAVA_17_PATH rather than embedding the expression in the shell script.
| File | Description |
|---|---|
| .github/workflows/e2e-versions.yml | Moves Java 17 output usage into env to avoid direct expression interpolation in a bash run: block. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Low
Sorry, something went wrong.
Comment thread
.github/workflows/e2e-versions.yml
Comment on lines
+725
to
+730
| env: | ||
| JAVA_17_PATH: ${{ steps.setup-java-17.outputs.path }} | ||
| run: | | ||
| echo "JAVA_HOME=$JAVA_HOME" | ||
| echo "Java 17 path=${{ steps.setup-java-17.outputs.path }}" | ||
| if [ "$JAVA_HOME" != "${{ steps.setup-java-17.outputs.path }}" ]; then | ||
| echo "Java 17 path=$JAVA_17_PATH" | ||
| if [ "$JAVA_HOME" != "$JAVA_17_PATH" ]; then |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Resolves a zizmor/template-injection code scanning alert where ${{ steps.setup-java-17.outputs.path }} was interpolated directly into a run shell block, allowing the step output to expand into attacker-controllable code.
Fix moves the expression into a step-level env variable and references it as a plain shell variable:
Related issue:
Code scanning alert #118
Check list: