Pull request overview

This pull request adds an opt-in jmod input to support installing Temurin JDKs with JMOD files (needed because Temurin JDK 24+ no longer includes JMODs in the default JDK archive). It extends the Temurin installer to optionally download the matching Adoptium “jmods” artifact, merge it into the installed JDK, and cache that JDK separately.

Changes:

• Adds a new jmod boolean input (action input + constants + wiring into installer options).
• Extends Temurin installation to optionally download and merge the “jmods” image and cache it under a distinct toolcache folder suffix.
• Updates docs and adds focused Temurin installer test coverage for the new behavior.

Review details

• Files reviewed: 7/9 changed files
• Comments generated: 2
• Review effort level: Low

Review details

src/distributions/temurin/installer.ts:180

• The JMODs archive extracted from Adoptium uses a JDK-like top-level directory that itself contains a jmods/ subdirectory. Copying the extracted root directory into ${javaHome}/jmods will nest paths (e.g., ${javaHome}/jmods/<extracted-root>/jmods/...) rather than placing the .jmod files directly under ${javaHome}/jmods.

Copy the jmods directory from within the extracted artifact (and account for macOS Contents/Home) instead of copying the artifact root.

    const jmodsDirectory = path.join(
      extractedJmodsPath,
      fs.readdirSync(extractedJmodsPath)[0]
    );
    fs.cpSync(jmodsDirectory, path.join(javaHome, 'jmods'), {recursive: true});

tests/distributors/temurin-installer.test.ts:520

• This test asserts the fs.cpSync source as the extracted artifact root (.../jdk-25-jmods). With the intended behavior of merging JMODs into the JDK, the copy source should be the jmods directory inside the extracted artifact (and Contents/Home/jmods on macOS). Update the expectation to match the correct copy semantics.

    );
    expect(spyCopySync).toHaveBeenCalledWith(
      path.join('/tmp/extracted-jmods', 'jdk-25-jmods'),
      process.platform === 'darwin'
        ? path.join('/tmp/extracted', 'jdk-25', 'Contents', 'Home', 'jmods')
        : path.join('/tmp/extracted', 'jdk-25', 'jmods'),
      {recursive: true}

• Files reviewed: 7/8 changed files
• Comments generated: 0 new
• Review effort level: Low

Review details

• Files reviewed: 7/8 changed files
• Comments generated: 0 new
• Review effort level: Low