Fix macOS e2e workflow assertions - #1184
Merged
brunoborges merged 1 commit intoJul 30, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Normalize ARM64 runner architecture when checking exported JAVA_HOME variables and skip the unsupported adopt-openj9 macOS arm64 version-file matrix entry. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: e78541cb-82b7-4fc2-8ffc-b1e5799efbce
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes macOS e2e workflow failures that occurred when macos-latest began resolving to ARM64 runners by aligning workflow assertions with the action’s exported JAVA_HOME_<major>_<arch> variable naming (the action uses canonical AARCH64, not the runner label ARM64). It also avoids a known-bad matrix combination where adopt-openj9 lacks macOS ARM64 builds for the tested version-file flow.
Changes:
- Normalize RUNNER_ARCH=ARM64 to AARCH64 in PowerShell assertions before checking JAVA_HOME_* variables.
- Exclude the adopt-openj9 + macos-latest matrix entry for version-file major.minor.patch tests.
| File | Description |
|---|---|
| .github/workflows/e2e-versions.yml | Updates macOS ARM64-related env var assertions and excludes an unsupported OpenJ9 macOS-latest matrix combination to restore e2e stability. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The macOS e2e workflow was failing after macos-latest resolved to an arm64 runner. The action exports Java home variables using AARCH64, while the workflow assertions used the runner label ARM64, so the checks looked for the wrong environment variable names.
This normalizes the workflow assertions from ARM64 to AARCH64 before checking JAVA_HOME_* variables. It also excludes the unsupported adopt-openj9 + macos-latest version-file matrix entry, since adopt-openj9 does not provide macOS arm64 builds for that Java version.
Related issue:
N/A
Check list: