Remove legacy Adopt distributions in v6 - #1185
Merged
brunoborges merged 2 commits intoJul 31, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copilot
AI
changed the title
[WIP] Remove AdoptOpenJDK and Adopt OpenJ9 distributions in v6
Remove legacy Adopt distributions in v6
Jul 30, 2026
brunoborges
marked this pull request as ready for review
July 30, 2026 21:45
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Review details
Suppressed comments (3)tests/distributors/distribution-factory.test.ts:127
- This test asserts legacy Adopt distributions return null, but the PR description/issue calls for a fail-fast error with explicit migration guidance. If getJavaDistribution is updated to throw (instead of returning null), this test should assert on the error message and the correct replacement distribution.
it.each(['adopt', 'adopt-hotspot', 'adopt-openj9'])(
'does not support legacy Adopt distribution %s',
async distributionName => {
expect(
await getJavaDistribution(distributionName, installerOptions('jdk'))
).toBeNull();
}
src/distributions/distribution-factory.ts:32
- Legacy Adopt distributions currently fall through to default: return null, which then turns into the generic error No supported distribution was found for input ... in src/setup-java.ts. The PR description/issue requires a hard, fail-fast error that tells users exactly what to migrate to (adopt/adopt-hotspot -> temurin, adopt-openj9 -> semeru).
switch (distributionName) {
case JavaDistribution.JdkFile: {
const {LocalDistribution} = await import('./local/installer.js');
return new LocalDistribution(normalizedInstallerOptions, jdkFile);
}
README.md:36
- The docs now state legacy Adopt distributions were removed, but .tool-versions parsing still silently remaps the asdf vendor prefix adoptopenjdk to temurin (see src/util.ts mapAsdfDistribution: adoptopenjdk: 'temurin'). This contradicts the PR description/issue requirement to remove .tool-versions adoptopenjdk* remapping and fail with a hard error instructing users to pick temurin or semeru explicitly (especially for adoptopenjdk-openj9, which currently collapses to adoptopenjdk and would map to Temurin).
- **Legacy AdoptOpenJDK distributions were removed.** Replace `adopt` or `adopt-hotspot` with `temurin`, and replace `adopt-openj9` with `semeru`.
- Files reviewed: 15/17 changed files
- Comments generated: 0 new
- Review effort level: Lite
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
AdoptOpenJDK distribution inputs are removed in v6 instead of being treated as aliases. Users must migrate HotSpot workflows to Temurin and OpenJ9 workflows to IBM Semeru.
Runtime behavior
Migration guidance
Repository updates
Related issue:
Handled by linked issue.
Check list: