Add an error condition for non jdk Microsoft OpenJDK build - #265
Merged
dmitry-shibanov merged 3 commits intoDec 21, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Hello @brcrista. Could you please take a look at these changes. |
Sorry, something went wrong.
brcrista
reviewed
Dec 16, 2021
Comment thread
src/distributions/microsoft/installer.ts
brcrista
approved these changes
Dec 17, 2021
Copy link
Copy Markdown
|
LGTM |
Sorry, something went wrong.
MaksimZhukov
approved these changes
Dec 20, 2021
brcrista
approved these changes
Dec 20, 2021
tdfacer
pushed a commit
to ifit/setup-java
that referenced
this pull request
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 more reviewers4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
In scope of this pull request we update documentation and add logic to throw an error for non jdk versions for Microsoft OpenJDK build. Microsoft OpenJDK build supports only jdk for now.
Related issue:
Check list: