FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Improve error handling for restore caching by dmitry-shibanov · Pull Request #297 · actions/setup-java · GitHub

Improve error handling for restore caching - #297

Closed
dmitry-shibanov wants to merge 2 commits into
actions:mainfrom
dmitry-shibanov:v-dmshib/fix-issue-with-buffer
Closed

Improve error handling for restore caching#297
dmitry-shibanov wants to merge 2 commits into
actions:mainfrom
dmitry-shibanov:v-dmshib/fix-issue-with-buffer

Conversation

Copy link
Copy Markdown
Contributor

Description:
In scope of this pull request we add error handling to throw error only for ValidationError.

Related issue: #295

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Copy link
Copy Markdown

Deposit through the bitcoin wallet for any help
bc1q5v34g2dym8c7x5mpfp7wdqp5hse38p99p4dggx

Copy link
Copy Markdown
Contributor Author

Hello @brcrista. Could you please take a look at this pull request?

brcrista left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I agree with the change, but how does it relate to #295?

brcrista requested a review from a team March 28, 2022 15:16

Copy link
Copy Markdown
Contributor

@actions/actions-cache, do you have any feedback? For context, the setup- actions use the @actions/cache package to cache dependencies directly, which lets you omit actions/cache as a separate step.

Copy link
Copy Markdown
Contributor Author

Hello @brcrista. Actually, as I checked the issue reproduces with node 16 only. On the previous action version it works as expected. I think it's related itself to the change of the default node version and buffer size. I could reproduce the same behaviour with action/cache when I removed this error handling logic and archive size was more than 2147483647.

Copy link
Copy Markdown
Contributor

might this be related to actions/toolkit#1030 ?

Copy link
Copy Markdown
Contributor Author

Thank you @aparna-ravindra. It works. I've updated the pull request.

Copy link
Copy Markdown
Contributor Author

I'm going to close the pull request because the issue was resolved in scope of this pull request #308

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL