Remove old dist/index.js file - #96
Merged
konradpabjan merged 2 commits intoAug 24, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
anthonysterling
approved these changes
Aug 24, 2020
anthonysterling
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Lovely, thanks @konradpabjan 🙇♂️
Sorry, something went wrong.
tdfacer
pushed a commit
to ifit/setup-java
that referenced
this pull request
Oct 7, 2025
* Remove old dist/index.js file * Misc fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After adding support for publishing packages with a GPG key, there is no longer a single dist/index.js file. Instead there is dist/setup/index.js and dist/cleanup/index.js because there is a main and post step:
setup-java/action.yml
Lines 56 to 57 in d34a7e4
This PR removes the old dist/index.js file that was not removed and it adds some clarification to the contributor docs about the files that @zeit/ncc creates.