Support .nvmrc - #338
Merged
MaksimZhukov merged 67 commits intoNov 29, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
hkaur008
marked this pull request as draft
September 30, 2021 19:41
This reverts commit 820128a.
Copy link
Copy Markdown
Contributor
Author
|
Is this reviewable now @Xlient I think we did all the tasks ! |
Sorry, something went wrong.
Xlient
suggested changes
Oct 5, 2021
added link to README * migrated contents of version-file-workflow.yml to versions.yml * further refactored parseNodeVersionFile() & tests * removed type annotations in catch ()
* added fail-fast to strategy in versions.yml * refactored logic in main that was causing test to fail
konradpabjan
approved these changes
Nov 16, 2021
Comment thread
docs/advanced-usage.md
Outdated
Comment thread
docs/advanced-usage.md
Outdated
Comment thread
README.md
Outdated
Comment thread
src/main.ts
Outdated
Comment thread
action.yml
Outdated
* fix grammar in README & Advance usage docs * update example in action.yml
Comment thread
src/main.ts
Comment thread
src/main.ts
MaksimZhukov
approved these changes
Nov 28, 2021
Closed
2 tasks
This was referenced Jan 10, 2022
akash1810
added a commit
to guardian/cdk
that referenced
this pull request
Jan 27, 2022
Since actions/setup-node#338, GH's setup-node Action understands `.nvmrc` files. This makes our `guardian/actions-setup-node` fork somewhat redundant now. Move to GH's Action so we can deprecate our fork.
2 tasks
deining
pushed a commit
to deining/setup-node
that referenced
this pull request
Nov 9, 2023
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.5.2 to 4.5.3. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v4.5.2...v4.5.3) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In scope of this pull request we add Node.js version file support. This pull request introduces new optional input: node-version-file, that accepts path (relative to repository root) to file containing Node.js version (for example .nvmrc).
The action will search for the Node.js version file and read the Node.js version if the file exists. If both inputs node-version and node-version-file are specified, the action will throw a warning and the node-version input will be used.
Example of yml
Related issue: #32
What's done: