Fix to run tests on non-x64 architecture - #502
Open
ganta wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
2 tasks
vsafonkin
approved these changes
Jun 1, 2022
marko-zivic-93
approved these changes
Jun 1, 2022
ganta
force-pushed
the
fix-to-run-tests-on-non-x86-arch
branch
from
0b2230a to
b858c04
Compare
March 22, 2023 02:12
Copy link
Copy Markdown
Contributor
Author
|
I have resolved the conflict. Could you please reconfirm? |
Sorry, something went wrong.
marko-zivic-93
approved these changes
Mar 22, 2023
deining
pushed a commit
to deining/setup-node
that referenced
this pull request
Nov 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 more reviewersAt least 1 approving review is required to merge this pull request.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The test fails when run on non-x86 architectures such as Apple Silicon.
The return value of os.arch() can be replaced using Jest's spyOn() so that tests can be run on non-x86 architectures, but this does not work as expected in certain cases.
setup-node/__tests__/installer.test.ts
Lines 54 to 55 in ed1a46e
In this case, os.arch() is called with the default parameter, so it cannot be replaced.
https://github.com/actions/toolkit/blob/8263c4d15d3a8616851e9c7762ce46fbb4f8c552/packages/tool-cache/src/tool-cache.ts#L638
Therefore, I have changed it to pass values instead of relying on default values.
Related issue:
N/A
Check list: