FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add support for node version codenames and keywords by JimiC · Pull Request #58 · actions/setup-node · GitHub

/ setup-node Public

Add support for node version codenames and keywords - #58

Closed
JimiC wants to merge 1 commit into
actions:masterfrom
JimiC:support_node_codename
ConversationCommits (1)ChecksFiles changed
Closed

Add support for node version codenames and keywords#58
JimiC wants to merge 1 commit into
actions:masterfrom
JimiC:support_node_codename

Conversation

JimiC commented Sep 13, 2019 •
edited
Loading

Copy link
Copy Markdown

Resolves #26

This PR adds support for node codenames (argon, boron etc) and selected keywords (latest, current, lts).

Resolving the codenames and keywords is fully automated and ensures future codenames support.

In order to do so, I took the liberty to refactor the code and test cases for better optimization and maintainability.

I'm aware that code reviewing will be a nightmare because of the many changes. I suggest having a look at the new code itself instead, to have a better understanding of it.

In case the refactoring is not acceptable, I'll try to provide a PR with minimum changes, but the code will be ugly.

Add support for node version codename
62a25ae 
Refactored for optimization and maintainability

JimiC commented Sep 13, 2019 •
edited
Loading

Copy link
Copy Markdown
Author

Suggestion: Since the refactoring done in this PR interferes with #42, I could also incorporate those changes in this PR.

Edit: I also didn't update README until we finalize the PR.

wesleytodd mentioned this pull request Sep 23, 2019
Closed
JimiC mentioned this pull request Sep 27, 2019
Closed

DanielRuf commented Jan 23, 2020

Copy link
Copy Markdown

latest would be great, as a solution you can already use '*'.

JimiC mentioned this pull request Feb 17, 2020
Merged

ExE-Boss commented Feb 20, 2020

Copy link
Copy Markdown

This PR seems to have a lot of out of scope changes in it.

JimiC commented Feb 20, 2020

Copy link
Copy Markdown
Author

Not going to update it if it's not going to be merged.

kakhaUrigashvili mentioned this pull request Apr 16, 2020
Merged
mciastek mentioned this pull request Sep 17, 2020
Merged

wdanilo commented Nov 2, 2020

Copy link
Copy Markdown

Why is this not merged? It would be important to me to indicate that I want my tests to run on the latest LTS node version. Right now I need to update it everywhere by hand.

bryanmacfarlane added the enhancement New feature or request label Jan 20, 2021
achingbrain mentioned this pull request Jan 23, 2021
Merged
davidmurdoch mentioned this pull request Feb 22, 2021
Merged

maxim-lobanov commented Jun 30, 2021

Copy link
Copy Markdown
Contributor

Fixed in #270

JimiC deleted the support_node_codename branch June 30, 2021 13:58
krzyk pushed a commit to krzyk/setup-node that referenced this pull request Apr 11, 2023
Merge pull request actions#58 from akamai/develop
4234ce3 
Feature/DEVPOPS-903
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support aliases like LTS

6 participants

Back | FazBrowse Home | New Git URL