Switch "pypy3" keyword to point to 3.6 for backward compatibility - #166
Merged
konradpabjan merged 1 commit intoDec 8, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
konradpabjan
approved these changes
Dec 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrating changes from #164 to v1 version. Should be merged when #164 is tested and validated
Currently, PyPy 2.7 and 3.6 are cached on Hosted images and 3.x selector works great.
In future, we are planning to add PyPy 3.7 too. In current implementation, selector 3.x will consume 3.7 and all customers will be switched automatically to 3.7 instead of 3.6 that could cause breaking changes.
We would like to make selector more specific to choose exact 3.6 to make sure that adding 3.7 to images won't break customers.
We are going to implement PyPy 3.7 support soon so customers will be able to select 3.6 and 3.7 separately.
Note:
Please pay attention that after this PR, core.setOutput('python-version', impl); will be set to pypy3.6 instead of pypy3. Not sure about impact from this change