FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update NPM packages by konradpabjan · Pull Request #75 · actions/setup-python · GitHub

/ setup-python Public

Update NPM packages - #75

Merged
konradpabjan merged 4 commits into
masterfrom
konradpabjan/npm-updates
Mar 26, 2020
ConversationCommits (4)ChecksFiles changed
Merged

Update NPM packages#75
konradpabjan merged 4 commits into
masterfrom
konradpabjan/npm-updates

Conversation

konradpabjan commented Mar 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Sanity check to make sure everything works before going to master: https://github.com/konradpabjan/Testing2/runs/533477128?check_suite_focus=true

This should make the security warning go away that we're seeing.

I used ncu to update all the packages (haven't found a better way to update all npm packages)
https://stackoverflow.com/questions/16073603/how-do-i-update-each-dependency-in-package-json-to-the-latest-version

Also npm run format-check is green on my windows box, but it's failing here?!? looks like it's just line endings so that can be ignored, still curious as to why (I've got CRLF in vscode and core.autocrlf set to true for git)?

konradpabjan requested a review from brcrista March 25, 2020 13:31

brcrista commented Mar 25, 2020

Copy link
Copy Markdown
Contributor

Why do we need to update all of the packages?

konradpabjan commented Mar 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Why do we need to update all of the packages?

Just going on an update spree. Dependabot has been submitting a few PRs here and there so I figure it's best to keep packages up to date: #73

Also these alerts: https://github.com/actions/setup-python/network/alerts

brcrista commented Mar 25, 2020

Copy link
Copy Markdown
Contributor

looks like it's just line endings so that can be ignored, still curious as to why (I've got CRLF in vscode and core.autocrlf set to true for git)?

A few tricks here to help:

  • You can see the actual line endings in Notepad++ if you show all characters.
  • With core.autocrlf, you can blow away your working tree (don't delete the .git directory of course) and then git checkout -f konradpabjan/npm-updates to force line ending normalization on all files.
  • To avoid problems in the future, you can add a .gitattributes file at the top level of the repo with the following contents:
* text=auto

.gitattributes will override anyone's local Git config, so we don't have to rely on everyone having the same core.autocrlf settings.

konradpabjan commented Mar 26, 2020

Copy link
Copy Markdown
Contributor Author

@brcrista figured it out, * text=auto is needed along with eol=lf. I suspect git might have some different settings during checkout on our runners which is why this weirdness was happening.

I followed the recommendations here: https://prettier.io/docs/en/options.html#end-of-line

konradpabjan merged commit 4ff1108 into master Mar 26, 2020
konradpabjan deleted the konradpabjan/npm-updates branch March 26, 2020 15:39
tdfacer pushed a commit to ifit/setup-python that referenced this pull request Oct 7, 2025
Update NPM packages (actions#75)
208d5b3 
* Update NPM packages

* Format using prettier

* Update node version in workflow

* Add .gitattributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
brcrista brcrista approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL