FIX: Extract zip win - #827
Conversation
Sorry, something went wrong.
|
@priyagupta108 I took the liberty to take a look at #819 and I think this changes should correct the issue. I tested it on my repo and it works fine (didn't do intensive testing though). |
Sorry, something went wrong.
RobPasMue
left a comment
There was a problem hiding this comment.
This will solve so many issues! Windows self-hosted runners could no longer use "v5" if the Python version requested was not available in the cache or in the system already. We can finally use the action as is without having to stick to "v4" or implement workarounds!
Sorry, something went wrong.
Related to #819 Changes consist in reordering extract utils to first attemps ExtractToDirectory and then Expand-Archive. For some reason the download CPython release was not correctly handled by Expand-Archive. This could be happening if the zip file was compressed using an unsupported compression method (e.g. through `zip` with Unix/linux).
|
I took the liberty to reproduce the error (fixed by this PR) on a github runner. The associated branch (https://github.com/SMoraisAnsys/setup-python/tree/test/no-pwshpath) consists in removing a part of the code of function extractZipWin(file, dest) in order to ensure that the runner uses the failing part of the code. PR that can be used to oversee the changes : https://github.com/SMoraisAnsys/setup-python/pull/1 |
Sorry, something went wrong.
|
@actions/setup-actions-team could we get this reviewed and merged soon? |
Sorry, something went wrong.
|
@aparnajyothi-y pointed out in #819 (comment) that this code comes from actions/toolkit. Perhaps a PR against https://github.com/actions/toolkit/blob/main/packages/tool-cache/src/tool-cache.ts would be better reviewed? |
Sorry, something went wrong.
As you mentioned, the problem seems to be related with actions/toolkit. However, the mentioned PR was created in October 2023. I don't think changes would be better reviewed there. |
Sorry, something went wrong.
|
I hear you, but I think what I meant is that the changes need to be applied there rather than here. Also, I don't think that linked PR would actually help this case. |
Sorry, something went wrong.
Sorry, something went wrong.
Description:
Changes consist in reordering extract utils to first attemps ExtractToDirectory and then Expand-Archive. For some reason the download CPython release was not correctly handled by Expand-Archive. This could be happening if the zip file was compressed using an unsupported compression method (e.g. through zip with Unix/Linux).
Related issue: #819
Check list: