Extend LIBRARY_PATH as well as LD_LIBRARY_PATH on Linux - #909
Open
tyrken wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
While this PR has been tested and Works-For-Me (tm), actions/python-versions#275 sounds like it would be a better fix if it works as advertised, gets released & the pythons rebuilt... |
Sorry, something went wrong.
Comment thread
dist/setup/index.js
| if (!libPath.split(':').includes(pyLibPath)) { | ||
| core.exportVariable('LD_LIBRARY_PATH', pyLibPath + libPath); | ||
| } | ||
| ensurePathInEnvVar('LIBRARY_PATH', pyLibPath); |
Copy link
Copy Markdown
There was a problem hiding this comment.
TBH, I wouldn't go with the route of LD_LIBRARY_PATH as some systems ( including containers) doesn't allow it as it's a security issue.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAt least 1 approving review is required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
On Linux we already set LD_LIBRARY_PATH to the lib folder under the extracted Python, to allow running apps to find libPython and other libraries. This is not enough to let gcc find those libraries during compilation, e.g. as some Python dependencies do when installing. For this we also need to add the lib folder to the LIBRARY_PATH env-var.
Related issue:
Should fix #275
Not sure if the suggestion to override AGENT_TOOLSDIRECTORY for Linux if the existing advanced-docs is needed any more. It certainly didn't work for me and between the two *LIBRARY_PATH env-vars that should be enough.
Check list: