RGBMatrix: document constructor arguments - #8319
Merged
dhalbert merged 5 commits intoAug 22, 2023
Merged
dhalbert merged 5 commits into
dhalbert merged 5 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
dhalbert
requested changes
Aug 22, 2023
dhalbert
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Yay! Style comments.
Sorry, something went wrong.
Comment thread
shared-bindings/rgbmatrix/RGBMatrix.c
Outdated
Comment on lines
+196
to
+200
| //| :param Sequence[digitalio.DigitalInOut] rgb_pins: The display's "RGB pins" | ||
| //| :param Sequence[digitalio.DigitalInOut] addr_pins: The display's "address pins" | ||
| //| :param digitalio.DigitalInOut clock_pin: The display's "clock pin" | ||
| //| :param digitalio.DigitalInOut latch_pin: The display's "latch pin" | ||
| //| :param digitalio.DigitalInOut output_enable_pin: The display's "output enable" pin |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
I am not sure why these are in quotes. It's not a "pretend" clock pin, which is sometimes what putting something in quotes means. I think you could drop the quotes. Also I would say "matrix" instead of "display".
Sorry, something went wrong.
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
fixed! & made some additional updates
Sorry, something went wrong.
dhalbert
approved these changes
Aug 22, 2023
dhalbert
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
👍
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #8283