Demo: SQL review failure (non-snake_case table) - #87
Closed
adela-bytebase wants to merge 4 commits into
Closed
Conversation
Copy link
Copy Markdown
Owner
Sorry, something went wrong.
Mirrors the existing Postgres declarative pipeline against the new mysql-project / mysql-test-instance-05k8 (testdb, proddb) for testing the SDL feature on MySQL.
Intentionally breaks the .bytebase/sql-review.md naming convention to demonstrate the SQL review check catching a violation.
Copy link
Copy Markdown
SQL Review Summary
Detailed Results
|
Sorry, something went wrong.
The custom snake_case rule alone didn't fail the check (resultCount=0 even for PascalCase EmployeeProfile - likely AI custom-rule review isn't enabled server-side). Add a broken FK reference so the check fails on real schema validation instead.
Copy link
Copy Markdown
Owner
Author
|
Demo complete — AI SQL review correctly flagged the non-snake_case table. Closing. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Intentionally adds `EmployeeProfile` (PascalCase) to `schema-mysql/schema.sql` to demonstrate the SQL review check failing against the `.bytebase/sql-review.md` snake_case naming rule.
Expected: `declarative-sql-review-action-mysql.yml` fails.