Minor corner-cases for OPL drivers - #287
Open
mywave82 wants to merge 5 commits into
Open
mywave82 wants to merge 5 commits into
mywave82 wants to merge 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…overity) Protect update() against negative and zero sample-request. The zero-samples request could potentially forward uninitatlized pointers which would be attempted to be filled with nothing.
* If mode set to OPL3 (not supported for this emulator), output[] contains random data. * Missing header file. * Explicit initialize mixbuf0, mixbuf1, mixbuf2, even if they are never accessed before being assigned.
* oldvol not initialized. * gotperms not initialized.
* Explicit initialize mixbuf0, mixbuf1, mixbuf2, even if they are never accessed before being assigned. Coverity static code-analyzer really dislikes non-initialized pointers.
* add checks to all register-offset parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are primarily to make static-code analyzer (Coverity) happy, but never hurts to ensure memory is initialized and range-test arguments when functions are public.