FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Huggingface spaces web demo by AK391 · Pull Request #13 · advimman/lama · GitHub

/ lama Public

Huggingface spaces web demo - #13

Merged
senya-ashukha merged 1 commit into
advimman:mainfrom
AK391:main
Oct 26, 2021
Merged

Huggingface spaces web demo#13
senya-ashukha merged 1 commit into
advimman:mainfrom
AK391:main

Conversation

AK391 commented Oct 16, 2021

Copy link
Copy Markdown
Contributor

easy to use web demo using gradio on huggingface spaces

Copy link
Copy Markdown
Collaborator

Hi @AK391,

Thank you for making this demo! I think an auto-generation of masks is a great idea.
Is it possible to add also a mask painting option? It might be great to give a user a choice.

AK391 commented Oct 18, 2021

Copy link
Copy Markdown
Contributor Author

@senya-ashukha yes there is a gradio sketchpad input in image components https://gradio.app/docs where a user can draw the mask but it wont be overlayed with the original image and will show separately in the interface

AK391 commented Oct 20, 2021

Copy link
Copy Markdown
Contributor Author

@senya-ashukha added a mask painting option check it out https://huggingface.co/spaces/akhaliq/lama

Copy link
Copy Markdown
Collaborator

@AK391 that is great, thank you! But the mask and results are squeezed compared to the original image. It is possible to correct this?

AK391 commented Oct 21, 2021

Copy link
Copy Markdown
Contributor Author

@senya-ashukha Hi the mask and input image are resized so that they match, unfortunately the mask currently cant be overlayed over the original image due to how the canvas input component works in gradio.

senya-ashukha commented Oct 21, 2021
edited
Loading

Copy link
Copy Markdown
Collaborator

Hi @AK391,

  1. No overlapping, get it, it is fine!
  2. But I believe the final image and the mask are squeezed and have a different size and aspect ratio. It does not look good IMO(
  3. Let's also show a masked image on the right instead of just a mask?

AK391 commented Oct 21, 2021

Copy link
Copy Markdown
Contributor Author

@senya-ashukha adding changes to keep aspect ratio
for 3 do you mean overlay the mask on top of the image to show on the right?

senya-ashukha commented Oct 21, 2021 via email
edited
Loading

Copy link
Copy Markdown
Collaborator

senya-ashukha merged commit 8f3e784 into advimman:main Oct 26, 2021

senya-ashukha commented Oct 26, 2021
edited
Loading

Copy link
Copy Markdown
Collaborator

Hi @AK391,

Thank you for making the great demo! I think the possible correction is minor anyway!
I've merged but moved the link to "Non-official 3rd party apps" section. And also I've added your account name next to it. Let me know if any correction is needed!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL