Add registerShader Texture Example to Materials Documentation - #4795
Merged
dmarcos merged 1 commit intoFeb 15, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Provides users a quick example link/picture so they can find how to implement Textures using registerShader easier.
Copy link
Copy Markdown
Member
|
Thanks! |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Congrats on your first contribution 🙌 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
I found it very difficult to find information on using textures in a registerShader setup. It's mostly described with the schema option, but doesn't have anything in the documentation currently that even mentions it. I ended up googling for examples, only to run into many historical discussions about whether or not to even add this into a-frame. Ultimately it was very confused and took several hours to sort out.
Changes proposed:
Add a link + gif demonstrating a registerShader custom shader which uses textures, where the texture can be specified using the Asset Managment System A-Frame has.