FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add Reverb G2 Support by zach-capalbo · Pull Request #4845 · aframevr/aframe · GitHub

/ aframe Public

Add Reverb G2 Support - #4845

Merged
dmarcos merged 4 commits into
aframevr:masterfrom
zach-capalbo:hp-reverb-g2
Apr 26, 2021
ConversationCommits (4)ChecksFiles changed
Merged

Add Reverb G2 Support#4845
dmarcos merged 4 commits into
aframevr:masterfrom
zach-capalbo:hp-reverb-g2

Conversation

zach-capalbo commented Apr 11, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description:

Adds the Reverb G2 controller as a supported controller

From #4823 (comment)

  • Copy magicleap-controls and rename to hp-mixed-reality-controls
  • Replace controller id with hp-mixed-reality as indicated in webxr profile
  • Point URL to appropriate model. Take models from the repo and submit to the A-Frame assets repo. Model scale adjustment might be necessary. I think we need to account for handennes. See oculus touch support for an example
  • Map buttons and axes according to the profile

Additional Changes Needed:

  • Add to necessary tracked control locations to be auto-configured (laser controls, etc)
  • Adjust copy-pasted code for handedness
  • Adjust model offset and rotation to match physical orientation

zach-capalbo mentioned this pull request Apr 11, 2021
Closed

dmarcos commented Apr 12, 2021

Copy link
Copy Markdown
Member

Thanks so much. This is the correct approach! Well done. I left a comment in the PR of the models.

dmarcos reviewed Apr 13, 2021
View reviewed changes
Comment thread src/components/hp-mixed-reality-controls.js Outdated
dmarcos reviewed Apr 13, 2021
View reviewed changes
Comment thread src/components/hp-mixed-reality-controls.js
/**
* Rotate the trigger button based on how hard the trigger is pressed.
*/
onButtonChanged: function (evt) {

dmarcos Apr 13, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Note. animate trigger and buttons on press if possible. If model is prepared for it.

zach-capalbo Apr 22, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Would you be willing to accept the hp-mixed-reality-controls without button animations initially, and then add button animations at a later time? That way Reverb G2 users will at least have a usable experience, rather than being stuck unable to use most a-frame apps.

dmarcos commented Apr 22, 2021

Copy link
Copy Markdown
Member

Thanks for sticking with this. Much appreciated. Have you checked if virtual and real controllers align? When integrating new controllers I test alignment by wearing headset and peeking inside / outside quickly to make sure the virtual and real controllers align?

zach-capalbo commented Apr 22, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for sticking with this. Much appreciated. Have you checked if virtual and real controllers align? When integrating new controllers I test alignment by wearing headset and peeking inside / outside quickly to make sure the virtual and real controllers align?

Yes, the latest commit adds a position and rotation offset which aligns the model to both the WMR controller display and to the physical controller (at least within the margin of error allowed by the G2 tracking)

dmarcos reviewed Apr 23, 2021
View reviewed changes
Comment thread src/components/hp-mixed-reality-controls.js Outdated
dmarcos reviewed Apr 23, 2021
View reviewed changes
Comment thread src/components/hp-mixed-reality-controls.js Outdated
dmarcos reviewed Apr 23, 2021
View reviewed changes
Comment thread src/components/hp-mixed-reality-controls.js Outdated
zach-capalbo changed the title Add Reverb G2 Support [WIP] Add Reverb G2 Support Apr 25, 2021

dmarcos commented Apr 26, 2021

Copy link
Copy Markdown
Member

Thank you!

dmarcos merged commit 9d0a603 into aframevr:master Apr 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dmarcos dmarcos left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL