FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use proper THREE.Cache API in a-assets.js by takahirox · Pull Request #4864 · aframevr/aframe · GitHub

Use proper THREE.Cache API in a-assets.js - #4864

Merged
dmarcos merged 1 commit into
aframevr:masterfrom
takahirox:ThreeCacheAdd
May 24, 2021
Merged

Use proper THREE.Cache API in a-assets.js#4864
dmarcos merged 1 commit into
aframevr:masterfrom
takahirox:ThreeCacheAdd

Conversation

Copy link
Copy Markdown
Collaborator

Fixes #4861

Description:

Refer to #4861 for the detail.

Changes proposed:

  • Replace THREE.Cache.files[url] = file with likely more proper API THREE.Cache.add(url, file).

dmarcos commented May 24, 2021

Copy link
Copy Markdown
Member

Thank you!

dmarcos merged commit bbd27c7 into aframevr:master May 24, 2021
takahirox deleted the ThreeCacheAdd branch May 24, 2021 09:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is THREE.Cache handling in a-assets.js correct?

2 participants


Back | FazBrowse Home | New Git URL