FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add ability to use grip instead of targetRay space by msub2 · Pull Request #5040 · aframevr/aframe · GitHub

Add ability to use grip instead of targetRay space - #5040

Merged
dmarcos merged 2 commits into
aframevr:masterfrom
msub2:tracked-controls-gripspace
Apr 21, 2022
Merged

Add ability to use grip instead of targetRay space#5040
dmarcos merged 2 commits into
aframevr:masterfrom
msub2:tracked-controls-gripspace

Conversation

msub2 commented Apr 12, 2022

Copy link
Copy Markdown
Contributor

Description:
tracked-controls-webxr currently uses targetRaySpace to report controller pose with no option to change it. This PR adds the ability to specify gripSpace over targetRaySpace, while still keeping targetRaySpace as the default.

Changes proposed:

  • Adds a space property on both tracked-controls and tracked-controls-webxr to allow the user to specify gripSpace over targetRaySpace.

dmarcos commented Apr 14, 2022

Copy link
Copy Markdown
Member

Thanks. What’s the use case?

msub2 commented Apr 14, 2022

Copy link
Copy Markdown
Contributor Author

I was working on a physics hands demo where I was using just tracked-controls to get controller position and wanted some cubes to stand in for hands, but they'd automatically be centered at the target ray point instead of just being in the center of my hands. It would also be useful if you're simulating something like the player holding a sword or other tool, which would make less sense being based around the target ray point. I just think this is easier than having to manually get references to the refSpace and frame, calling getPose on that, and then setting it or having to apply some manual offset to the controller position.

dmarcos commented Apr 21, 2022
edited
Loading

Copy link
Copy Markdown
Member

Thanks for the PR and patience! Great stuff

dmarcos merged commit f5fbc2a into aframevr:master Apr 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL