| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Note that package-lock.json needs to be in the repo for the GitHub Actions npm cache to properly work. It will reuse the npm cache if package-lock.json didn't change. codecov upload should work, but I can't test it on my fork. It finds the tests/coverage/lcov.info file and try to upload it to codecov, but I get a 404 there. I set up testing only on chrome, but you can enable it for firefox if you want, it's just commented. |
Sorry, something went wrong.
|
I enabled the tests on firefox, it seems fine. You'll see if there are some tests that are randomly failing on Firefox or not later on other PRs. If there is an issue with it, just comment it. You can merge this PR and close the first one, or merge the first one, then I rebase this one and you merge, as you wish. |
Sorry, something went wrong.
|
Compared to the previous travis config, I added a check for the minified build that runs npm run dist. |
Sorry, something went wrong.
|
codecov upload is working, it uploaded the results from this PR: |
Sorry, something went wrong.
| karma.conf.js | ||
| node_modules | ||
| npm-debug.log* | ||
| package-lock.json |
There was a problem hiding this comment.
is this intentional?
Sorry, something went wrong.
There was a problem hiding this comment.
Yes. I explained it in #5092 (comment)
see documentation https://github.com/actions/setup-node#caching-global-packages-data
Sorry, something went wrong.
|
It needs rebase! |
Sorry, something went wrong.
|
I rebased. |
Sorry, something went wrong.
|
About putting package-lock.json in the repo, mainly to have the npm cache in CI, it may add a burden to you to update the file from time to time to keep up to date dependencies for patch versions of some of the dependencies. |
Sorry, something went wrong.
|
done, good to merge |
Sorry, something went wrong.
|
Thanks so much! This is great work. Tests don't get much love. I let them rotten a little bit 😄 |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This is based on #5091. I can rebase this PR once the first one is merged.
This PR removes travis and the old codecov uploader, replaces it by GitHub Actions.
You can see a successful pipeline here
https://github.com/vincentfretin/aframe/actions/runs/2868225958