FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Encoding should match scene's color management settings by diarmidmackenzie · Pull Request #5157 · aframevr/aframe · GitHub

Encoding should match scene's color management settings - #5157

Merged
dmarcos merged 1 commit into
aframevr:masterfrom
diarmidmackenzie:fix-5014
Nov 20, 2022
Merged

Encoding should match scene's color management settings#5157
dmarcos merged 1 commit into
aframevr:masterfrom
diarmidmackenzie:fix-5014

Conversation

diarmidmackenzie commented Nov 19, 2022
edited
Loading

Copy link
Copy Markdown
Contributor

Description:

Fix for #5014

Changes proposed:

  • encoding setting for screenshot is read from renderer, rather than assuming sRGB or Linear
  • unit tests to check interaction between colorManagement setting on scene, and encoding used in screenshots.

dmarcos commented Nov 20, 2022

Copy link
Copy Markdown
Member

Thank you so much! 🏆 🥳

dmarcos merged commit 11bdac3 into aframevr:master Nov 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL