Webxr unit tests - #5227
Merged
dmarcos merged 3 commits intoFeb 6, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
diarmidmackenzie
marked this pull request as ready for review
February 1, 2023 20:47
dmarcos
reviewed
Feb 6, 2023
Comment thread
tests/__init.test.js
Outdated
| getDevice: function () { return {requestPresent: function () {}}; }, | ||
| isPresenting: function () { return true; }, | ||
| setDevice: function () {}, | ||
| setSession: function () { |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
can do one liner
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
fixed
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thank you very much! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
As noted in #5217, and one reason that bug #5221 slipped through - the Enter / Exit VR tests for a-scene are still entirely focussed on WebVR rather than WebXR.
This PR adds some tests for WebXR
Changes proposed:
I approached this as follows;
I doubt this gives us perfect coverage of WebXR, but it should give good coverage of a broad range of key scenarios around entry to / exit from VR.
I have also confirmed that this set of tests would have caught the bug fixed under #5221.
Some very minor changes to a-scene also made, to allow simulation of WebXR availability via the el.hasWebXR flag.