hand-controls: rotates models to match WebXR definition (fix #4848) - #5261
Merged
dmarcos merged 2 commits intoMar 20, 2023
Merged
hand-controls: rotates models to match WebXR definition (fix #4848)#5261dmarcos merged 2 commits into
dmarcos merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Documentation: https://developer.mozilla.org/en-US/docs/Web/API/WebXR_Device_API/Inputs#facing_and_targeting |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks!. I think we have to check for sceneEl.hasWebXR before applying the offset so WebVR (Firefox) still works as before. I would also add a comment in the offset: // The WebXR standard defines the grip space such that a cylinder held in a closed hand points along the Z axis. ./ // The models currently have such a cylinder point along the X-Axis. var modelOrientationXOffset = sceneEl.hasWebXR ? xxx : 0; ... |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thank you! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #4848
The WebXR standard now defines the grip space such that a cylinder held in a closed hand points along the Z axis. The models currently have such a cylinder point along the X-Axis.
Changes proposed:
There are two approaches
I'm fine with either, but I lack knowledge of 3D tools (such as Blender) to implement the second approach.