| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks for doing this work.
Sorry, something went wrong.
|
The text in https://github.com/aframevr/aframe/blob/master/docs/introduction/faq.md#can-i-use-a-frame-offline-or-self-hosted would also need to be modified. |
Sorry, something went wrong.
I'd like to handle that as a separate PR. I don't think the text as it stands needs to change for this PR to be OK - everything it says is still true, even after this code change. More work needed to fully solve #5119, but I'd like to tackle this one bit at a time. |
Sorry, something went wrong.
|
it also be cool to add an assets archive for loacal deployment. Including fonts, controllers models etc. I has to manualy figure out which files are required for local deployment and download one by one... |
Sorry, something went wrong.
|
@nightgryphon You can clone the assets repo actually, I commented about it here #5119 (comment) |
Sorry, something went wrong.
|
@vincentfretin Ohh! I've missed that repo. It can be a good idea to add a comment line with repo url near the constant and later in the docs. Also it is good to note which folders are actually required. |
Sorry, something went wrong.
|
Thanks! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Description:
As per #5119
Changes proposed:
Replace hardcoded instances of https://cdn.aframe.io/ with a global variable AFRAME_ROOT_CDN.
Based on @vincentfretin's suggestion here