FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use global variable for CDN root directory by diarmidmackenzie · Pull Request #5333 · aframevr/aframe · GitHub

Use global variable for CDN root directory - #5333

Merged
dmarcos merged 2 commits into
aframevr:masterfrom
diarmidmackenzie:global-var-for-cdn-url
Jul 17, 2023
Merged

Use global variable for CDN root directory#5333
dmarcos merged 2 commits into
aframevr:masterfrom
diarmidmackenzie:global-var-for-cdn-url

Conversation

diarmidmackenzie commented Jul 9, 2023
edited
Loading

Copy link
Copy Markdown
Contributor

Description:

As per #5119

Changes proposed:

Replace hardcoded instances of https://cdn.aframe.io/ with a global variable AFRAME_ROOT_CDN.

Based on @vincentfretin's suggestion here

vincentfretin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for doing this work.

Comment thread src/constants/index.js Outdated

Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor Author

The text in https://github.com/aframevr/aframe/blob/master/docs/introduction/faq.md#can-i-use-a-frame-offline-or-self-hosted would also need to be modified.

I'd like to handle that as a separate PR.

I don't think the text as it stands needs to change for this PR to be OK - everything it says is still true, even after this code change.

More work needed to fully solve #5119, but I'd like to tackle this one bit at a time.

Copy link
Copy Markdown
Contributor

it also be cool to add an assets archive for loacal deployment. Including fonts, controllers models etc. I has to manualy figure out which files are required for local deployment and download one by one...

Copy link
Copy Markdown
Contributor

@nightgryphon You can clone the assets repo actually, I commented about it here #5119 (comment)

Copy link
Copy Markdown
Contributor

@vincentfretin Ohh! I've missed that repo. It can be a good idea to add a comment line with repo url near the constant and later in the docs. Also it is good to note which folders are actually required.

dmarcos commented Jul 17, 2023

Copy link
Copy Markdown
Member

Thanks!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL