FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixed various small errors in examples by mrxz · Pull Request #5343 · aframevr/aframe · GitHub

Fixed various small errors in examples - #5343

Merged
dmarcos merged 1 commit into
aframevr:masterfrom
mrxz:examples-fixes
Jul 24, 2023
Merged

Fixed various small errors in examples#5343
dmarcos merged 1 commit into
aframevr:masterfrom
mrxz:examples-fixes

Conversation

mrxz commented Jul 23, 2023

Copy link
Copy Markdown
Contributor

Description:
Tested some tooling I'm working on and found several small issues with the various examples in this repository. This PR addresses them.

Changes proposed:

  • Removed the "flythrough" boilerplate. It referenced a non-existing image, used an invalid "thickness" property of <a-box> and wasn't listed in the main examples index.html
  • Updated anime-UI to use the core hide-on-enter-ar component and (re)enabled AR button.
  • Ensure <a-mixin> is always properly closed with an end tag (it isn't a void element)
  • Fix various small typos, invalid values and delimiters

dmarcos commented Jul 24, 2023

Copy link
Copy Markdown
Member

Thank you!

dmarcos merged commit 76904ca into aframevr:master Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL