Description:
When removing the fog component, the fog wouldn't actually be removed but instead rendered "ineffective" by adjusting the near and far values. This however has two issues:
Fog type exponential doesn't use near and far meaning the fog would still be visible after removal
Shaders would still perform fog calculations for no reason
Changes proposed:
Instead of adjusting fog when removing, outright set it to null (Three.js default value)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When removing the fog component, the fog wouldn't actually be removed but instead rendered "ineffective" by adjusting the near and far values. This however has two issues:
Changes proposed: