FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix fog removal from scene by mrxz · Pull Request #5418 · aframevr/aframe · GitHub

Fix fog removal from scene - #5418

Merged
dmarcos merged 2 commits into
aframevr:masterfrom
mrxz:fix-fog-removal
Dec 19, 2023
Merged

Fix fog removal from scene#5418
dmarcos merged 2 commits into
aframevr:masterfrom
mrxz:fix-fog-removal

Conversation

mrxz commented Dec 19, 2023

Copy link
Copy Markdown
Contributor

Description:
When removing the fog component, the fog wouldn't actually be removed but instead rendered "ineffective" by adjusting the near and far values. This however has two issues:

  • Fog type exponential doesn't use near and far meaning the fog would still be visible after removal
  • Shaders would still perform fog calculations for no reason

Changes proposed:

dmarcos commented Dec 19, 2023

Copy link
Copy Markdown
Member

Thank you!

dmarcos merged commit 8e4f387 into aframevr:master Dec 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL