Only update position and rotation of wristObject3D when joint poses are available - #5438
Merged
dmarcos merged 1 commit intoJan 25, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Yes. We should probably prevent / disable collision calculations if hands are not tracking (have disappeared) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks so much for this! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The issue reported in #5437 is caused by the wristObject3D in the hand-tracking-controls component ending up with NaN in its matrix. This happens when no joint poses are available, and causes subsequent computations (like bounding box overlap) to give incorrect results.
This PR simply checks that pose information is present before updating the wristObject3D. This does mean that the object in question remains at its last location and orientation. For short intermittent lack of pose information this is likely desirable, but for longer period this might be counter-intuitive.
Changes proposed: