use debug ^4.3.4 fixes #4612 - #5508
Merged
dmarcos merged 6 commits intoApr 9, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Yeah debug for was to remove the timestamps. Can we get rid of them? Thanks |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Yes, overwrite the debug.formatArgs, and add the colors and remove the Time works, Idea from debug-js/debug#582 (comment) Original Code uses const/let https://github.com/debug-js/debug/blob/f66cb2d9f729e1a592e72d3698e3b75329d75a25/src/browser.js#L146 @dmarcos should this be changed to vars? |
Sorry, something went wrong.
dmarcos
reviewed
Apr 6, 2024
Comment thread
src/utils/debug.js
Outdated
Copy link
Copy Markdown
Member
|
Yes we don't use let / var. Code style has to be consistent with rest of code base. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks so much! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using upstream debug ^4.3.4
tested with http://localhost:8080/showcase/spatial-ui/
old debug: