FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make isCompatibleTexture check stricter by requiring equal source by mrxz · Pull Request #5529 · aframevr/aframe · GitHub

Make isCompatibleTexture check stricter by requiring equal source - #5529

Merged
dmarcos merged 1 commit into
aframevr:masterfrom
mrxz:texture-compatibility-check
May 29, 2024
Merged

Make isCompatibleTexture check stricter by requiring equal source#5529
dmarcos merged 1 commit into
aframevr:masterfrom
mrxz:texture-compatibility-check

Conversation

mrxz commented May 29, 2024

Copy link
Copy Markdown
Contributor

Description:
The compatibility check for textures allowed changes of the underlying source. Depending on the state of the texture in Three.js this might actually not be supported, causing incorrect reference counting, potentially leading to an exception upon disposal of the texture.

Instead of trying to inspect the internal state to make a decision, it's easier to make the check considerably stricter. This PR now requires the source to match the prior source. While this does lead to more texture instance being created when changing images, the corresponding Source (actual image data) and WebGLTexture resources remain shared whenever possible.

Changes proposed:

  • Make isCompatibleTexture check stricter by requiring source to match previous source.

dmarcos commented May 29, 2024

Copy link
Copy Markdown
Member

Thanks!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL