Add assetStringify for asset based properties - #5544
Merged
dmarcos merged 1 commit intoJun 18, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thank you! |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks so much! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Asset based property types could either be a string, or directly refer to an HTMLElement (using an id selector, or passing instance to it). The stringification used for these property types was just the default one, which works for strings, but fails for HTMLElement instances.
This PR introduces an assetStringify that attempts to construct a suitable id selector. In case that isn't possible it will resort to using the src attribute instead.
See aframevr/aframe-inspector#722 for some context where this caused issues when using flushToDOM.
Changes proposed: