FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use simple pinch end threshold avoiding repeated pinch starts by mrxz · Pull Request #5609 · aframevr/aframe · GitHub

Use simple pinch end threshold avoiding repeated pinch starts - #5609

Merged
dmarcos merged 1 commit into
aframevr:masterfrom
mrxz:fix-pinch-end
Nov 18, 2024
Merged

Use simple pinch end threshold avoiding repeated pinch starts#5609
dmarcos merged 1 commit into
aframevr:masterfrom
mrxz:fix-pinch-end

Conversation

mrxz commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

Description:
A partial revert of 8341329 fixing #5505.

Having a fixed pinch end distance that is larger than pinch start should avoid any repeated pinch start events. The original change was made to reduce/avoid a pinch being too "sticky", so I've kept the new pinch end distance closer to the pinch start than before as a compromise.

Main goal is to get the pinching behaviour in a reliable and working state again. Other solutions can be explored either in community components or incrementally refined in the core.

Changes proposed:

  • Replace dynamic pinch end distance threshold criteria with fixed threshold

dmarcos commented Nov 18, 2024
edited
Loading

Copy link
Copy Markdown
Member

I think this needs some adjustment. Tried with this on Meta Quest 3

https://glitch.com/edit/#!/a-pickle-rick?path=index.html%3A10%3A44

Three script tags. One with this PR, master and 1.6.0. Master and 1.6.0 work as expected. I can pinch and grab the model. With this PR the model spins without control.

mrxz commented Nov 18, 2024

Copy link
Copy Markdown
Contributor Author

I can pinch and grab the model. With this PR the model spins without control.

That's unrelated to this PR. The model spinning already happened on master, but just got fixed in #5565. This PR didn't include that fix yet, but I've now rebased it. The reproduction in the linked issue (#5505) can also be used to test the change.

dmarcos commented Nov 18, 2024

Copy link
Copy Markdown
Member

Thanks!

dmarcos merged commit 4e137a8 into aframevr:master Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL