| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
I think this needs some adjustment. Tried with this on Meta Quest 3 https://glitch.com/edit/#!/a-pickle-rick?path=index.html%3A10%3A44 Three script tags. One with this PR, master and 1.6.0. Master and 1.6.0 work as expected. I can pinch and grab the model. With this PR the model spins without control. |
Sorry, something went wrong.
That's unrelated to this PR. The model spinning already happened on master, but just got fixed in #5565. This PR didn't include that fix yet, but I've now rebased it. The reproduction in the linked issue (#5505) can also be used to test the change. |
Sorry, something went wrong.
|
Thanks! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Description:
A partial revert of 8341329 fixing #5505.
Having a fixed pinch end distance that is larger than pinch start should avoid any repeated pinch start events. The original change was made to reduce/avoid a pinch being too "sticky", so I've kept the new pinch end distance closer to the pinch start than before as a compromise.
Main goal is to get the pinching behaviour in a reliable and working state again. Other solutions can be explored either in community components or incrementally refined in the core.
Changes proposed: