Check if XRSession exists before adding inputsourceschange listener - #5631
Merged
dmarcos merged 1 commit intoJan 22, 2025
Merged
Check if XRSession exists before adding inputsourceschange listener#5631dmarcos merged 1 commit into
dmarcos merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
dmarcos
reviewed
Jan 20, 2025
Comment thread
src/systems/tracked-controls.js
Outdated
mrxz
force-pushed
the
fix-tracked-controls-entervr
branch
from
916c0ac to
be0d4f1
Compare
January 21, 2025 07:47
Copy link
Copy Markdown
Member
|
Thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The tracked-controls system unconditionally adds an inputsourcechange listener when "entering VR". However, the enter-vr event is also used when entering fullscreen mode, in which case an error occurs. This is a regression introduced in fd90434.
This PR simply adds a check to make sure there is an XRSession before adding the event listener.
Changes proposed: