FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make the inspector work with post-processing enabled by vincentfretin · Pull Request #5684 · aframevr/aframe · GitHub

Make the inspector work with post-processing enabled - #5684

Merged
dmarcos merged 1 commit into
aframevr:masterfrom
vincentfretin:fix-inspector-with-bloom
Mar 5, 2025
Merged

Make the inspector work with post-processing enabled#5684
dmarcos merged 1 commit into
aframevr:masterfrom
vincentfretin:fix-inspector-with-bloom

Conversation

Copy link
Copy Markdown
Contributor

Description:

Make the inspector work with post-processing enabled.

Changes proposed:

  • Set camera on the renderPass so it uses the correct camera when using the inspector, there is no performance impact doing that, we just set a variable
  • Also don't recreate the RenderPass instance when toggling the bloom effect

dmarcos commented Mar 5, 2025

Copy link
Copy Markdown
Member

Thanks!

dmarcos merged commit fb67c01 into aframevr:master Mar 5, 2025
vincentfretin deleted the fix-inspector-with-bloom branch March 5, 2025 18:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL