Thanks, nice to have a simpler stats component. There are still a couple more files related to rStats that can be removed as well, namely: vendor/rStats.js, vendor/rStats.extras.js and src/style/rStats.css. As well as the line in index.js including the .css file:

Functionally there is an annoying edge-case. With post-processing we override the render method similar to what stats-gl does under the hood. But this means that the order in which the components initialize matter. I'm wondering if we should perhaps manually call stats.begin()/.end()/.update() from scene.js. This would avoid that issue as well as include the .tick/.tock execution time in the CPU metric.

Can we remove the unnecessary files? Can we deal with post-processing separately ideally without coupling with a-scene?

I have cleaned up the unused rStats files for now, but the alternative approach mentioned by @mrxz involves a larger overhaul. I don't think I understand how that would be done or what implications it would have.

No worries, it's more thinking out loud than anything concrete. The way post-processing is done leads to conflicts with components that patch/hook into rendering (screenshot (#5677) and stats). Ideally there'd be a clean interface for these components provided by a-scene as it controls the render loop.

The fact that the measured CPU time does not include any system or component logic is a bigger issue IMO. Users would expect it to reflect those as well. But merging this PR as-is, is fine. The above mentioned issue is something that needs to be addressed anyway, at which point the stats can be updated as well.

Needs the tests fixed

Thanks so much!

@arvind-iyer removing the stats component doesn't properly remove the two graphs, it just freeze them. You can test in the console with AFRAME.scenes[0].removeAttribute("stats"); Can you please look at it?

The number of draw calls was an interesting metric for me, but I can still access the stats with a console.table:

console.table(AFRAME.scenes[0].renderer.info.memory);
console.table(AFRAME.scenes[0].renderer.info.render);

@diarmidmackenzie your stats-panel component will probably be broken by this change, you may want to get back some of the previous code into your component.

@arvind-iyer removing the stats component doesn't properly remove the two graphs, it just freeze them. You can test in the console with AFRAME.scenes[0].removeAttribute("stats"); Can you please look at it?

I fixed it in #5733