| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
PR ended pretty big |
Sorry, something went wrong.
Not really? The majority is the auto-generated attribute tables for primitives in the docs. Kind of unavoidable when material properties change. The actual changes are minimal: npot out and mag/minFilter in: docs/components/material.md | 3 ++- src/components/layer.js | 2 +- src/components/material.js | 6 +++++- src/extras/primitives/primitives/a-sky.js | 2 +- src/extras/primitives/primitives/a-videosphere.js | 2 +- src/utils/material.js | 23 +++++++++++------------ 6 files changed, 21 insertions(+), 17 deletions(-) |
Sorry, something went wrong.
|
I verified with some console.log that by default on a texture we have wrapS = THREE.ClampToEdgeWrapping; wrapT = THREE.ClampToEdgeWrapping; magFilter = THREE.LinearFilter; minFilter = THREE.LinearMipmapLinearFilter; so here the default on the minFilter and magFilter properties in this PR matches that and just setting minFilter to linear indeed does the same thing than the previous code. Also I confirm this is still needed to set minFilter here. So the changes in the PR looks good to me. Thanks for the work @mrxz |
Sorry, something went wrong.
|
Thanks! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Description:
As discussed in #5706 the npot property was only intended for working with non-power-of-two textures in WebGL 1. It's being used in several places to indirectly set the minFilter to THREE.LinearFiltering. This PR introduces minFilter and magFilter properties allowing the filtering methods to be set directly and explicitly.
Changes proposed: