Set texture.generateMipmaps according to specified minFilter - #5726
Merged
dmarcos merged 1 commit intoMay 27, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Change looks good to me. Especially now that we explicitly expose mag/minFilter as properties, it's nice to avoid generating mipmaps when we know they aren't needed. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thank you |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Set texture.generateMipmaps according to specified minFilter.
Since mrdoob/three.js#29677 that's included since three r170 you need to set texture.generateMipmaps to false explicitly if using minFilter 'linear' or 'nearest' to not generate mipmaps.
Changes proposed: