Use loadCubeMapTexture instead of CubeTextureLoader for light probes - #5735
Merged
dmarcos merged 1 commit intoJun 2, 2025
Merged
Use loadCubeMapTexture instead of CubeTextureLoader for light probes#5735dmarcos merged 1 commit into
dmarcos merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thank you! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5734
Description:
Probe lights used an instance of THREE.CubeTextureLoader to create a CubeTexture which was then fed into the LightProbeGenerator. With #5454 the possible values for srcs for an envMap were broadened, meaning they were no longer guaranteed to be URLs, but could also contain HTMLImageElement.
The loadCubeMapTexture method on the material system already handles all possible values. This PR replaces the light component to use loadCubeMapTexture instead of manually using a CubeTextureLoader instance.
Changes proposed: