| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
That would be good if someone having one of those headset could verify this is working properly. |
Sorry, something went wrong.
…ed-controls component, only logitech-mx-ink-controls and meta-touch-controls were correct (fix aframevr#5772)
|
thanks! |
Sorry, something went wrong.
Haven't run any tests, but I do recall testing it when removing the webvr variant and not running into any issues. I believe it still works due to the following pattern in the components:
In short, there are two checks/filters that use a different ID value. The former still guarantees the right xyz-controls becomes active, and the latter matches any and all controller (of the expected handedness). So this would've only caused issues in case there's more than one controller with the same handedness, which is very uncommon. Looking at the overall flow, it would be nicer if there's only one lookup/check, completely avoiding the possibility of the two mismatching. But at least this fixes the potential issue for now. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Description:
Fix all controls to use id instead of idPrefix when setting the tracked-controls component, only logitech-mx-ink-controls and meta-touch-controls were correct (fix #5772)
The tests pass with three 177